cloud-fan commented on code in PR #48830:
URL: https://github.com/apache/spark/pull/48830#discussion_r1856667657
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/WriteToDataSourceV2Exec.scala:
##########
@@ -631,7 +649,19 @@ private[v2] trait V2CreateTableAsSelectBaseExec extends
LeafV2CommandExec {
qe.assertCommandExecuted()
table match {
- case st: StagedTable => st.commitStagedChanges()
+ case st: StagedTable =>
+ st.commitStagedChanges()
+
+ catalog match {
+ case stagingTableCatalog: StagingTableCatalog
+ if stagingTableCatalog.supportedCustomMetrics().nonEmpty =>
Review Comment:
I think we can simply check `st.reportDriverMetrics.nonEmpty`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
