olaky commented on code in PR #48830: URL: https://github.com/apache/spark/pull/48830#discussion_r1859065577
########## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/WriteToDataSourceV2Exec.scala: ########## @@ -148,6 +150,8 @@ case class ReplaceTableAsSelectExec( val properties = CatalogV2Util.convertTableProperties(tableSpec) + override val metrics: Map[String, SQLMetric] = commitMetrics(catalog) Review Comment: V2CreateTableAsSelectBaseExec does not have access to catalog. But I changed the signature of commitMetrics() to only accept StagedTableCatalog and removed it here, that looks cleaner -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
