olaky commented on code in PR #48830: URL: https://github.com/apache/spark/pull/48830#discussion_r1857371443
########## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/WriteToDataSourceV2Exec.scala: ########## @@ -75,6 +75,8 @@ case class CreateTableAsSelectExec( val properties = CatalogV2Util.convertTableProperties(tableSpec) + override val metrics: Map[String, SQLMetric] = commitMetrics(catalog) Review Comment: Good catch, this will actually not work because we do not fill the values -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
