cloud-fan commented on code in PR #48830:
URL: https://github.com/apache/spark/pull/48830#discussion_r1860448097


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/WriteToDataSourceV2Exec.scala:
##########
@@ -612,6 +616,12 @@ case class DeltaWithMetadataWritingSparkTask(
 private[v2] trait V2CreateTableAsSelectBaseExec extends LeafV2CommandExec {
   override def output: Seq[Attribute] = Nil
 
+  protected def commitMetrics(tableCatalog: StagingTableCatalog): Map[String, 
SQLMetric] = {

Review Comment:
   maybe move this to `DataSourceV2Utils` as well so that we can reuse it in 
`ReplaceTableExec`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to