grundprinzip commented on code in PR #49569:
URL: https://github.com/apache/spark/pull/49569#discussion_r1922304924
##########
mllib/src/main/scala/org/apache/spark/ml/classification/DecisionTreeClassifier.scala:
##########
@@ -192,6 +192,10 @@ class DecisionTreeClassificationModel private[ml] (
private[ml] def this(rootNode: Node, numFeatures: Int, numClasses: Int) =
this(Identifiable.randomUID("dtc"), rootNode, numFeatures, numClasses)
+ // For ml connect only
+ @Since("4.0.0")
+ private[ml] def this() = this(Node.dummyNode, 0, 0)
Review Comment:
it's an interesting case where we use package private here. According to the
service loader documentation the no-args constructor needs to be public but
apparently this gets lost in the detail between Scala and Java?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
