grundprinzip commented on PR #49569: URL: https://github.com/apache/spark/pull/49569#issuecomment-2602277847
@wbo4958 @WeichenXu123 there is another good refactoring we could /should do. All of the ML classes now have a public no args constructor and we essentially don't really use that. However, for most of the classes we're then explicitly calling the constructor with a string arg to instantiate the class. I'm wondering if we should just make the uid param a part of the interface and then we can just use the instantiate class from the service loader and then don't need to invoke the constructor again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
