wbo4958 commented on code in PR #49569:
URL: https://github.com/apache/spark/pull/49569#discussion_r1922336110
##########
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala:
##########
@@ -1076,6 +1076,10 @@ class LogisticRegressionModel private[spark] (
this(uid, new DenseMatrix(1, coefficients.size, coefficients.toArray,
isTransposed = true),
Vectors.dense(intercept), 2, isMultinomial = false)
+ // For ml connect only
+ @Since("4.0.0")
+ private[spark] def this() = this(Identifiable.randomUID("logreg"),
Vectors.zeros(0), 0)
Review Comment:
I'm following
https://github.com/apache/spark/pull/49569/files/3d0d823032a31f402476513595addc0322fece4a#diff-ed184a69391654654c5a418abe036f159a350814500780d2f50ec17fc2feb2dcR1075
which is a private[spark], but yes, we could make it private[ml]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
