wbo4958 commented on PR #49569: URL: https://github.com/apache/spark/pull/49569#issuecomment-2602439885
Hi @grundprinzip, I'm not quite understanding "I'm wondering if we should just make the uid param a part of the interface and then we can just use the instantiate class from the service loader and then don't need to invoke the constructor again." What do you mean "make the uid as a part of interface"? For now, we're explicitly passing "uid" created in python client side when instantiating the ML classes. If we don't use "uid", then the "uid" between python side and server side will be in-consistent, I don't know if there will be an issue. Maybe @WeichenXu123 and @zhengruifeng have some thoughts on this optimization. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
