pan3793 commented on code in PR #52741:
URL: https://github.com/apache/spark/pull/52741#discussion_r2464369274
##########
sql/connect/client/jdbc/src/main/scala/org/apache/spark/sql/connect/client/jdbc/SparkConnectDatabaseMetaData.scala:
##########
@@ -112,76 +96,55 @@ class SparkConnectDatabaseMetaData(conn:
SparkConnectConnection) extends Databas
override def getExtraNameCharacters: String = ""
- override def supportsAlterTableWithAddColumn: Boolean =
- throw new SQLFeatureNotSupportedException
+ override def supportsAlterTableWithAddColumn: Boolean = true
- override def supportsAlterTableWithDropColumn: Boolean =
- throw new SQLFeatureNotSupportedException
+ override def supportsAlterTableWithDropColumn: Boolean = true
- override def supportsColumnAliasing: Boolean =
- throw new SQLFeatureNotSupportedException
+ override def supportsColumnAliasing: Boolean = true
- override def nullPlusNonNullIsNull: Boolean =
- throw new SQLFeatureNotSupportedException
+ override def nullPlusNonNullIsNull: Boolean = true
override def supportsConvert: Boolean =
throw new SQLFeatureNotSupportedException
override def supportsConvert(fromType: Int, toType: Int): Boolean =
throw new SQLFeatureNotSupportedException
- override def supportsTableCorrelationNames: Boolean =
- throw new SQLFeatureNotSupportedException
+ override def supportsTableCorrelationNames: Boolean = true
- override def supportsDifferentTableCorrelationNames: Boolean =
- throw new SQLFeatureNotSupportedException
+ override def supportsDifferentTableCorrelationNames: Boolean = false
- override def supportsExpressionsInOrderBy: Boolean =
- throw new SQLFeatureNotSupportedException
+ override def supportsExpressionsInOrderBy: Boolean = true
- override def supportsOrderByUnrelated: Boolean =
- throw new SQLFeatureNotSupportedException
+ override def supportsOrderByUnrelated: Boolean = true
override def supportsGroupBy: Boolean = true
- override def supportsGroupByUnrelated: Boolean =
- throw new SQLFeatureNotSupportedException
+ override def supportsGroupByUnrelated: Boolean = true
- override def supportsGroupByBeyondSelect: Boolean =
- throw new SQLFeatureNotSupportedException
+ override def supportsGroupByBeyondSelect: Boolean = true
- override def supportsLikeEscapeClause: Boolean =
- throw new SQLFeatureNotSupportedException
+ override def supportsLikeEscapeClause: Boolean = true
- override def supportsMultipleResultSets: Boolean =
- throw new SQLFeatureNotSupportedException
+ override def supportsMultipleResultSets: Boolean = false
- override def supportsMultipleTransactions: Boolean =
- throw new SQLFeatureNotSupportedException
+ override def supportsMultipleTransactions: Boolean = false
Review Comment:
Databricks JDBC v1.0.10-oss returns `true`, but IMO Spark SQL does not
support transactions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
