vrozov commented on code in PR #53121:
URL: https://github.com/apache/spark/pull/53121#discussion_r2547703107


##########
sql/core/src/test/resources/sql-tests/inputs/identifier-clause.sql:
##########
@@ -172,6 +172,7 @@ SELECT my_table.* FROM VALUES (1, 2) AS 
IDENTIFIER('my_table')(IDENTIFIER('c1'),
 WITH identifier('v')(identifier('c1')) AS (VALUES(1)) (SELECT c1 FROM v);
 CREATE OR REPLACE VIEW v(IDENTIFIER('c1')) AS VALUES(1);
 SELECT c1 FROM v;
+DROP VIEW v;

Review Comment:
   It does not matter here if `DROP VIEW v` errors out or not. The goal is to 
cleanup and if the view does not exist (in the legacy case), both `SELECT` and 
`DROP` would error out consistently. The error does not affect anything.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to