vrozov commented on PR #53121: URL: https://github.com/apache/spark/pull/53121#issuecomment-3603190982
@cloud-fan > Yes if the view is not guaranteed to be created. In the case of `identifier-clause.sql`, the view is guaranteed to be created. If it is not created, the test would fail. > I'll be surprised if you don't agree with the expectation Expectations are 1. View is created, select succeeds, and drop succeeds in case of `identifier-clause.sql` 2. View is not created, select fails, and drop fails in case of `identifier-clause-legacy.sql` 3. Optionally, you can use `IF EXIST` clause, but in that case, it should be consistent across all usages of `DROP` clause. I do agree that "less noise" is preferred (for example large number of warnings during compilation), but I don't agree that it applies here. Errors and warnings are not always "noise". Golden files are **designed to handle both positive and negative cases**, and in the case of `identifier-clause-legacy.sql`, it is simply the negative case, not "noise". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
