cloud-fan commented on code in PR #53121:
URL: https://github.com/apache/spark/pull/53121#discussion_r2554556745
##########
sql/core/src/test/resources/sql-tests/inputs/identifier-clause.sql:
##########
@@ -172,6 +172,7 @@ SELECT my_table.* FROM VALUES (1, 2) AS
IDENTIFIER('my_table')(IDENTIFIER('c1'),
WITH identifier('v')(identifier('c1')) AS (VALUES(1)) (SELECT c1 FROM v);
CREATE OR REPLACE VIEW v(IDENTIFIER('c1')) AS VALUES(1);
SELECT c1 FROM v;
+DROP VIEW v;
Review Comment:
The cleanup code should be as less noisy as possible. Maybe we should have a
clear separation between testing code and cleanup code in the golden file test
framework, so that we don't commit anything for the cleanup code in the golden
file. The `SELECT` one line above is clearly a testing code.
Thanks @dongjoon-hyun for quickly addressing this issue properly!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
