vrozov commented on PR #53121: URL: https://github.com/apache/spark/pull/53121#issuecomment-3572248744
Hi @dongjoon-hyun and @cloud-fan, Please explain how this [DROP VIEW v;](https://github.com/apache/spark/blob/d14209c6ffba991b1d8ca9580708dea1ee37920e/sql/core/src/test/resources/sql-tests/inputs/identifier-clause.sql#L183) is different from [DROP VIEW test_view;](https://github.com/apache/spark/blob/d14209c6ffba991b1d8ca9580708dea1ee37920e/sql/core/src/test/resources/sql-tests/inputs/identifier-clause.sql#L321)? The later one causes the same [error](https://github.com/apache/spark/blob/d14209c6ffba991b1d8ca9580708dea1ee37920e/sql/core/src/test/resources/sql-tests/results/identifier-clause-legacy.sql.out#L2464) and it is (unnecessary) clean up code as well. I think the error in the legacy case does not affect anything, and it is not obvious, is hard to maintain without extra comments or looking into `.out` files for "legacy" case, or knowing the history of why `IF EXIST` is there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
