SavicStefan commented on code in PR #53541:
URL: https://github.com/apache/spark/pull/53541#discussion_r2634899804
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalog.scala:
##########
@@ -117,7 +117,8 @@ class JDBCTableCatalog extends TableCatalog
JdbcUtils.dropTable(conn, getTableName(ident), options)
true
} catch {
- case _: SQLException => false
+ case e: SQLException if dialect.isObjectNotFoundException(e) =>
+ false
Review Comment:
This makes sense, but we need for "table does not exists" to return false,
because that is how API is designed, if we convert SQLException to Spark
exception that we can't do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
