dusantism-db commented on code in PR #53541:
URL: https://github.com/apache/spark/pull/53541#discussion_r2635066297
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalog.scala:
##########
@@ -113,11 +113,24 @@ class JDBCTableCatalog extends TableCatalog
override def dropTable(ident: Identifier): Boolean = {
checkNamespace(ident.namespace())
JdbcUtils.withConnection(options) { conn =>
- try {
- JdbcUtils.dropTable(conn, getTableName(ident), options)
- true
- } catch {
- case _: SQLException => false
+ JdbcUtils.classifyException(
+ condition = "FAILED_JDBC.DROP_TABLE",
Review Comment:
I don't think `FAILED_JDBC.DROP_TABLE` exists as an error class. You have to
add it to `error-conditions.json`. Also, we should really add some tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
