urosstan-db commented on code in PR #53541:
URL: https://github.com/apache/spark/pull/53541#discussion_r2639325429
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalog.scala:
##########
@@ -113,11 +113,24 @@ class JDBCTableCatalog extends TableCatalog
override def dropTable(ident: Identifier): Boolean = {
checkNamespace(ident.namespace())
JdbcUtils.withConnection(options) { conn =>
- try {
- JdbcUtils.dropTable(conn, getTableName(ident), options)
- true
- } catch {
- case _: SQLException => false
+ JdbcUtils.classifyException(
+ condition = "FAILED_JDBC.DROP_TABLE",
+ messageParameters = Map(
+ "url" -> options.getRedactUrl(),
+ "tableName" -> toSQLId(ident)),
+ dialect,
+ description = s"Failed to drop table: $ident",
+ isRuntime = true) {
+ try {
+ JdbcUtils.dropTable(conn, getTableName(ident), options)
+ true
+ } catch {
+ // TableCatalog.dropTable API is designed to return false
+ // only in case table does not exist.
+ case e: SQLException if dialect.isObjectNotFoundException(e) =>
+ false
+ // All other SQLExceptions get classified and propagated
Review Comment:
it seems we miss one space here?
```suggestion
// All other SQLExceptions get classified and propagated
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
