dusantism-db commented on code in PR #53541:
URL: https://github.com/apache/spark/pull/53541#discussion_r2634927794
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalog.scala:
##########
@@ -117,7 +117,8 @@ class JDBCTableCatalog extends TableCatalog
JdbcUtils.dropTable(conn, getTableName(ident), options)
true
} catch {
- case _: SQLException => false
+ case e: SQLException if dialect.isObjectNotFoundException(e) =>
+ false
Review Comment:
I get that, but you already special cased it right? We should classify the
exception if some other exception is thrown
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
