davidm-db commented on code in PR #56439:
URL: https://github.com/apache/spark/pull/56439#discussion_r3394598900
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/SerializerBuildHelper.scala:
##########
@@ -384,8 +384,6 @@ object SerializerBuildHelper {
case TimestampEncoder(false) => createSerializerForSqlTimestamp(input)
case InstantEncoder(false) => createSerializerForJavaInstant(input)
case LocalDateTimeEncoder => createSerializerForLocalDateTime(input)
- case LocalTimeEncoder if !SQLConf.get.isTimeTypeEnabled =>
- throw
org.apache.spark.sql.errors.QueryCompilationErrors.unsupportedTimeTypeError()
case LocalTimeEncoder => createSerializerForLocalTime(input)
Review Comment:
completely agree, that was my intent as well, but it was late and I didn't
notice that Claude didn't remove everything. thanks for catching it!
on the section question - yes, we should follow up with another PR specific
to TIME type where we clean-up all the non-framework code now that we don't
have the framework flag anymore. I left that out of this PR since this is flag
specific, not TIME specific, and wanted to keep it simple. I only touched TIME
related code that would otherwise become completely unguarded (by a framework
or TIME flag) as a consequence of removing the framework flag. everything else
I thought of doing in a follow up!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
