MaxGekk commented on code in PR #56439:
URL: https://github.com/apache/spark/pull/56439#discussion_r3399174537
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/types/ops/TimeTypeOps.scala:
##########
@@ -92,7 +94,19 @@ case class TimeTypeOps(override val t: TimeType) extends
TimeTypeApiOps(t) with
// ==================== Optional Operations ====================
+ // Building a TIME serializer/deserializer requires the TIME type to be
enabled. The framework
+ // dispatch at the head of Serializer/DeserializerBuildHelper routes
LocalTimeEncoder through
+ // these methods, so this is the single gate on the encoder path. Throw
rather than return None
+ // so the dispatch surfaces UNSUPPORTED_TIME_TYPE instead of falling through
to the default
+ // match, which no longer handles LocalTimeEncoder.
Review Comment:
"no longer" reads relative to this PR's deletion — after merge, the durable
phrasing is what the match does now:
```suggestion
// match, which does not handle LocalTimeEncoder.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
