costas-db commented on code in PR #56439:
URL: https://github.com/apache/spark/pull/56439#discussion_r3400219476
##########
sql/api/src/main/scala/org/apache/spark/sql/types/ops/TypeApiOps.scala:
##########
@@ -187,23 +186,19 @@ object TypeApiOps {
def apply(
dt: DataType,
zoneId: => ZoneId =
SparkDateTimeUtils.getZoneId(SqlApiConf.get.sessionLocalTimeZone))
- : Option[TypeApiOps] = {
- if (!SqlApiConf.get.typesFrameworkEnabled) return None
- dt match {
- case tt: TimeType => Some(new TimeTypeApiOps(tt))
- case t: TimestampNTZNanosType => Some(new TimestampNTZNanosTypeApiOps(t))
- case t: TimestampLTZNanosType => Some(new TimestampLTZNanosTypeApiOps(t,
zoneId))
- // Add new types here - single registration point
- case _ => None
- }
+ : Option[TypeApiOps] = dt match {
Review Comment:
With this configuration gone, should we update this comment in Row.scala?
```
// A public Row holds the external java.time.LocalTime for a TimeType
column (SPARK-54451).
// With the Types Framework off, TypeApiOps returns None and we land
here, so render the
// LocalTime directly, mirroring HiveResult's legacy fallback. The
Long case below is the
// internal representation that a public Row never holds; it stays for
non-Row callers.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
