costas-db commented on code in PR #56439: URL: https://github.com/apache/spark/pull/56439#discussion_r3400169392
########## sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/types/ops/TimeTypeOpsSuite.scala: ########## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.catalyst.types.ops + +import org.apache.spark.SparkFunSuite +import org.apache.spark.sql.AnalysisException +import org.apache.spark.sql.catalyst.{DeserializerBuildHelper, SerializerBuildHelper} +import org.apache.spark.sql.catalyst.encoders.AgnosticEncoders.LocalTimeEncoder +import org.apache.spark.sql.catalyst.plans.SQLHelper +import org.apache.spark.sql.internal.SQLConf + +/** + * Tests for the Types Framework wiring of TimeType. + * + * The TIME-type-enabled gate lives in TimeTypeOps.createSerializer / createDeserializer; the + * framework dispatch at the head of Serializer/DeserializerBuildHelper routes LocalTimeEncoder + * through it. Disabling spark.sql.timeType.enabled must therefore still reject building a TIME + * serializer/deserializer with UNSUPPORTED_TIME_TYPE, rather than silently producing one. + */ +class TimeTypeOpsSuite extends SparkFunSuite with SQLHelper { Review Comment: nit: TimeTypeOpsSuite only asserts the negative (rejection) path. The positive path (enabled → builds a serializer/deserializer) is covered indirectly by the existing encoder suites, but adding a positive assertion in the same suite would lock in the gate's both-directions behavior and guard against a future regression that makes it throw unconditionally. Cheap insurance, optional. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
