venkata91 commented on PR #57016: URL: https://github.com/apache/spark/pull/57016#issuecomment-4897587039
Thanks for the thorough review, @sunchao! Addressed in the latest push (`8629e174e53`): - **[P2] job tag not path-safe** — fixed. The operation-detail endpoint now looks up by `operationId` (a UUID) via a new secondary KVStore index, instead of the `jobTag` which embeds the raw user id. Added a `tenant/alice` regression test proving list→detail works, plus a store-level index test that also covers the History Server replay path. - **Pagination** — added SQL-style `offset`/`length` query params to both the `/sessions` and `/operations` list endpoints, and documented them in `monitoring.md`. - **Reduced-detail controls** — I skipped a `details=false` toggle here on purpose: unlike the SQL API (whose `details` skips the heavy plan-graph/metrics payload), the Connect `ExecutionData` is all lightweight scalar fields, so a toggle would add API surface without meaningfully reducing the response. Happy to add it if you'd prefer symmetry with the SQL API. All connect REST suites pass locally on the current master (rebased). The DTO wire-contract fields you flagged (ms timestamps, `0` sentinels, `CLOSED` terminal state) are unchanged and match the existing Connect UI/history representation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
