ulysses-you commented on PR #57396: URL: https://github.com/apache/spark/pull/57396#issuecomment-5040957969
Thanks for the thorough review @peter-toth! Addressed all three in `2b05aa93ee0`: 1. **Window order-sensitivity** — kept on purpose (only refines tie order for a non-unique window `ORDER BY`, already non-deterministic), documented the distinction from `CollectMetricsExec` at the `isOrderPreserving` entries, and softened the PR description. 2. **Window-to-sort-aggregate test** — the old data had `c` constant within `(a, b)`; switched to `id % 13` + tie-safe `RANK()` so the widening genuinely reorders window ties while the result stays stable. 3. **`SortAggregateExec` branch** — confirmed unreachable and removed it (and the `resultExpressions` rename path); the canonical case traverses the `Window`, not the aggregate. Replied inline with details on each. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
