ulysses-you commented on PR #57396: URL: https://github.com/apache/spark/pull/57396#issuecomment-5041715547
Thanks @sunchao! Addressed both in `dd42f7318f7`: - **[P1] Non-deterministic project/filter** — reproduced (the sort was pushed below `Project[..., rand(0)]`). Now gated on determinism, mirroring `EliminateSorts.canEliminateSort`: `ProjectExec` on `projectList.forall(_.deterministic)`, `FilterExec` on `condition.deterministic`. - **[P2] Cardinality reducers** — made crossing `FilterExec`/`WindowGroupLimitExec` opt-in via a new internal config `spark.sql.execution.pushDownLocalSort.throughCardinalityReducer` (default `false`), so by default the rule never moves the wider sort below a selective reducer. Added plan-level tests for both (non-deterministic project/filter left unchanged; filter crossed only when the reducer config is on). Replied inline with details. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
