ulysses-you commented on PR #57396: URL: https://github.com/apache/spark/pull/57396#issuecomment-5041981661
Thanks for the approval @sunchao! Addressed both non-blocking [P3] follow-ups: - **Synced the PR description with the final code** — removed `SortAggregateExec` from the traversed operators, and documented that `FilterExec`/`WindowGroupLimitExec` are crossed only when `spark.sql.execution.pushDownLocalSort.throughCardinalityReducer` (default `false`) is enabled, plus the determinism guard on project/filter. - **Strengthened the AQE assertion** (`b6503d817a0`) — `checkNumSorts` now executes the query before inspecting the plan, so under AQE it checks the final adaptive plan (after query-stage materialization/replanning) rather than the initial plan. The `WindowGroupLimitExec` coverage suggestion from the earlier thread: it is now gated behind the reducer config and covered indirectly by the reducer-gating test; happy to add a dedicated `WindowGroupLimitExec` traversal test if you think it is worth it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
