aleksandar-trajkovic-db commented on code in PR #59140:
URL: https://github.com/apache/spark/pull/59140#discussion_r4155245214
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalog.scala:
##########
@@ -153,8 +153,8 @@ class JDBCTableCatalog extends TableCatalog
override def loadTable(ident: Identifier): Table = {
JdbcUtils.withConnection(options) { conn =>
- val optionsWithTableName = new JDBCOptions(
- options.parameters + (JDBCOptions.JDBC_TABLE_NAME ->
getTableName(ident)))
+ val tableOptions = new JDBCOptions(options.parameters +
+ (JDBCOptions.JDBC_TABLE_NAME -> getTableName(ident)) ++
JDBCOptions.planTimeOptions)
Review Comment:
OptionsTranslator is not present in OSS. I don't think think is overkill, it
is the cleanest way of stamping the decision during the planning stage, for it
to not change in the execution change in case of a flag flip
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
