aleksandar-trajkovic-db commented on code in PR #59140:
URL: https://github.com/apache/spark/pull/59140#discussion_r4165393052
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala:
##########
@@ -400,10 +395,11 @@ object JdbcUtils extends Logging with SQLConfHelper {
dialect: JdbcDialect,
schema: StructType,
inputMetrics: InputMetrics,
- fetchAndTransformToInternalRowsMetric: Option[SQLMetric] = None):
Iterator[InternalRow] = {
+ fetchAndTransformToInternalRowsMetric: Option[SQLMetric] = None,
+ options: Option[JDBCOptions] = None): Iterator[InternalRow] = {
Review Comment:
After further investigation, it seems that all the paths that do not have
JdbcOptions are not used anywhere in production code and only in a few small
tests. I also don't really think a foreign table read can be done without
JdbcOptions, so I don't think this is an issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
