aleksandar-trajkovic-db commented on code in PR #59140:
URL: https://github.com/apache/spark/pull/59140#discussion_r4155308539


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCOptions.scala:
##########
@@ -379,4 +387,12 @@ object JDBCOptions {
   val JDBC_PREFER_TIMESTAMP_NTZ = newOption("preferTimestampNTZ")
   val JDBC_PREFER_TIMESTAMP_NANOS = newOption("preferTimestampNanos")
   val JDBC_HINT_STRING = newOption("hint")
+  // Internal: pinned by the V2 catalog via planTimeOptions. newOption keeps 
it out of the driver
+  // connection properties.
+  val JDBC_LEGACY_ORACLE_TIMESTAMP_NTZ_MAPPING = 
newOption("__legacyOracleTimestampNTZMapping")

Review Comment:
   Agreed, I've made the option generic



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to