milastdbx commented on code in PR #59140:
URL: https://github.com/apache/spark/pull/59140#discussion_r4164835290
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala:
##########
@@ -400,10 +395,11 @@ object JdbcUtils extends Logging with SQLConfHelper {
dialect: JdbcDialect,
schema: StructType,
inputMetrics: InputMetrics,
- fetchAndTransformToInternalRowsMetric: Option[SQLMetric] = None):
Iterator[InternalRow] = {
+ fetchAndTransformToInternalRowsMetric: Option[SQLMetric] = None,
+ options: Option[JDBCOptions] = None): Iterator[InternalRow] = {
Review Comment:
Isn't this a problem ?
how will this codepath do proper conversion to WallClockNTZ if options are
not passed ?
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCOptions.scala:
##########
@@ -265,6 +265,14 @@ class JDBCOptions(
.map(_.toBoolean)
.getOrElse(false)
+ // Frozen plan-time wall-clock decision. A dialect pins it via
planTimeOptions at each planning
Review Comment:
this is outdated now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
