Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/7250#discussion_r34214800
--- Diff: core/src/main/scala/org/apache/spark/metrics/MetricsSystem.scala
---
@@ -73,7 +73,7 @@ private[spark] class MetricsSystem private (
private[this] val metricsConfig = new MetricsConfig(conf)
private val sinks = new mutable.ArrayBuffer[Sink]
- private val sources = new mutable.ArrayBuffer[Source]
+ val sources = new mutable.ArrayBuffer[Source]
--- End diff --
I think it would be better not to loose the restriction to expose this to
the public user just only for test convenience. you could refer
[here](https://github.com/apache/spark/blob/master/core/src/test/scala/org/apache/spark/ExecutorAllocationManagerSuite.scala#L782)
to see how to test with private field.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
