Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/7250#discussion_r34232194
--- Diff:
streaming/src/test/scala/org/apache/spark/streaming/StreamingContextSuite.scala
---
@@ -297,6 +296,23 @@ class StreamingContextSuite extends SparkFunSuite with
BeforeAndAfter with Timeo
Thread.sleep(100)
}
+ test("de-register codahale metrics on stop()") {
--- End diff --
Can you expand the test to cover both registering and deregistering the
metrics. so check after start as well as after stop.
Also, rather than count, a more robust check is to find the StreamingSource
in MetricSystem.sources. You will have to access private field
StreamingContext.streamingSource and MetricSystem.sources.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
