Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/7250#discussion_r34217232
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/StreamingContext.scala ---
@@ -674,6 +676,8 @@ class StreamingContext private[streaming] (
logWarning("StreamingContext has already been stopped")
case ACTIVE =>
scheduler.stop(stopGracefully)
+ // De-registering Streaming Metrics of the StreamingContext
+ env.metricsSystem.removeSource(streamingSource)
--- End diff --
I think here remove the source in `ACTIVE` state may introduce some corner
case problem. For example, since metrics source is added when
StreamingContext's state is `INITIALIZED`, if we met exception at this point,
we will never change the state into `ACTIVE`, so metrics source cannot be
removed, since you only assume the state is `ACTIVE` to remove the source. What
do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
