Github user nssalian commented on a diff in the pull request:
https://github.com/apache/spark/pull/7250#discussion_r34217790
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/StreamingContext.scala ---
@@ -674,6 +676,8 @@ class StreamingContext private[streaming] (
logWarning("StreamingContext has already been stopped")
case ACTIVE =>
scheduler.stop(stopGracefully)
+ // De-registering Streaming Metrics of the StreamingContext
+ env.metricsSystem.removeSource(streamingSource)
--- End diff --
The idea was to register at the call of the `start()`.
So, based on your comment, that would mean registering the sources after
the state is set to INITIALIZED and before.
`def start(): Unit = synchronized {
// Registering Streaming Metrics at the start of the StreamingContext
assert(env != null)
assert(env.metricsSystem != null)
env.metricsSystem.registerSource(streamingSource)`
Makes sense to have it after `INITIALIZED` and before the synchronized
block of `ACTIVE` and `STOPPED`.
@tdas, could add more light.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
