Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7480#discussion_r35155083
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashJoin.scala ---
@@ -61,8 +70,13 @@ trait HashJoin {
// Mutable per row objects.
private[this] val joinRow = new JoinedRow2
+ private[this] val resultProjection: Projection = if (supportUnsafe) {
--- End diff --
Within this file, it only looks like `resultProjection` is called from
within an `if(supportUnsafe)` branch. However, I think we do need to guard the
creation of this `UnsafeProjection` behind this `if` to make sure that we don't
try to generate it in the non-Unsafe case. Therefore, this seems fine to me;
the `else` branch will never get hit but I suppose it's better to have a safe
alternative there instead of `null`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
