Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7480#discussion_r35156499
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/rowFormatConverters.scala
 ---
    @@ -29,6 +29,9 @@ import org.apache.spark.sql.catalyst.rules.Rule
      */
     @DeveloperApi
     case class ConvertToUnsafe(child: SparkPlan) extends UnaryNode {
    +
    +  require(UnsafeProjection.canSupport(child.schema), s"Cannot convert 
${child.schema} to Unsafe")
    --- End diff --
    
    This change looks good to me; thanks for suggesting this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to