Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7480#discussion_r35156428
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala
 ---
    @@ -148,3 +148,81 @@ private[joins] object HashedRelation {
         }
       }
     }
    +
    +
    +/**
    + * A HashedRelation for UnsafeRow, which is backed by BytesToBytesMap that 
maps the key into a
    + * sequence of values.
    + *
    + * TODO(davies): use BytesToBytesMap
    + */
    +private[joins] final class UnsafeHashedRelation(
    +    private var hashTable: JavaHashMap[UnsafeRow, 
CompactBuffer[UnsafeRow]])
    +  extends HashedRelation with Externalizable {
    +
    +  def this() = this(null)  // Needed for serialization
    --- End diff --
    
    Can the serialization-only constructor be private?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to