Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/7480#discussion_r35157704
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashSemiJoin.scala
---
@@ -32,34 +32,45 @@ trait HashSemiJoin {
override def output: Seq[Attribute] = left.output
- @transient protected lazy val rightKeyGenerator: Projection =
- newProjection(rightKeys, right.output)
+ protected[this] def supportUnsafe: Boolean = {
+ (self.codegenEnabled && UnsafeProjection.canSupport(leftKeys)
+ && UnsafeProjection.canSupport(rightKeys)
+ && UnsafeProjection.canSupport(left.schema))
+ }
+
+ override def outputsUnsafeRows: Boolean = right.outputsUnsafeRows
--- End diff --
Even we can support that the children can have different Row
representation, this still correct. Because SemiJoin is kind of filter on
`right`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
