Github user lirui-intel commented on a diff in the pull request:

    https://github.com/apache/spark/pull/892#discussion_r13474171
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
    @@ -182,15 +189,16 @@ private[spark] class TaskSetManager(
         for (loc <- tasks(index).preferredLocations) {
           for (execId <- loc.executorId) {
             if (sched.isExecutorAlive(execId)) {
    -          addTo(pendingTasksForExecutor.getOrElseUpdate(execId, new 
ArrayBuffer))
               hadAliveLocations = true
    --- End diff --
    
    This check is used when we add a task to pending lists. If the task has any 
preferred location available (executor / host / rack), we won't add it to 
pendingTasksWithNoPrefs. Do you mean check for executor and host is redundant?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to