Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/892#discussion_r13474668
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
@@ -182,15 +189,16 @@ private[spark] class TaskSetManager(
for (loc <- tasks(index).preferredLocations) {
for (execId <- loc.executorId) {
if (sched.isExecutorAlive(execId)) {
- addTo(pendingTasksForExecutor.getOrElseUpdate(execId, new
ArrayBuffer))
hadAliveLocations = true
--- End diff --
Yes -- if the executor is alive (so if the if statement on line 191
evaluates to true), then there will certainly be an executor alive on the host
(the if-statement on line 196), and hadAliveLocations will be set to true on
line 197. So this line is not needed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
