Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/1056#discussion_r14888926
--- Diff:
core/src/main/scala/org/apache/spark/storage/BlockManagerMasterActor.scala ---
@@ -52,25 +52,24 @@ class BlockManagerMasterActor(val isLocal: Boolean,
conf: SparkConf, listenerBus
private val akkaTimeout = AkkaUtils.askTimeout(conf)
- val slaveTimeout = conf.get("spark.storage.blockManagerSlaveTimeoutMs",
- "" + (BlockManager.getHeartBeatFrequency(conf) * 3)).toLong
+ val slaveTimeout =
conf.getLong("spark.storage.blockManagerSlaveTimeoutMs",
+ (conf.getInt("spark.executor.heartbeatInterval", 2000) * 3))
--- End diff --
No huge reason, just that it avoids nesting the `conf.get`s and makes it
easier to see what the final value is (imagine if you had 5 more gets). Though
I just noticed that here you can't do that easily because of the `* 3`, so
scratch that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
