Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/1056#discussion_r15203311
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -154,6 +160,16 @@ class DAGScheduler(
eventProcessActor ! CompletionEvent(task, reason, result,
accumUpdates, taskInfo, taskMetrics)
}
+ def executorHeartbeat(execId: String, taskMetrics: Array[(Long, Int,
TaskMetrics)],
--- End diff --
Can we rename this to something more explicit, something like
`executorHeartbeatReceived`? This is also more consistent with other methods in
this actor (e.g. `executorLost`, `taskEnded`). From the name itself it's not
super clear whether we're sending or receiving the heartbeat.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
