Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/1056#discussion_r15203570
--- Diff:
core/src/main/scala/org/apache/spark/storage/BlockManagerMasterActor.scala ---
@@ -230,6 +229,10 @@ class BlockManagerMasterActor(val isLocal: Boolean,
conf: SparkConf, listenerBus
blockManagerIdByExecutor.get(execId).foreach(removeBlockManager)
}
+ /**
+ * Returns true if everything works out, false if the driver does not
know about the given block
+ * manager, which means the block manager should re-register.
--- End diff --
How about `Return false if the driver ..., true otherwise.`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
