Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1056#discussion_r15204465
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala 
---
    @@ -154,6 +160,16 @@ class DAGScheduler(
         eventProcessActor ! CompletionEvent(task, reason, result, 
accumUpdates, taskInfo, taskMetrics)
       }
     
    +  def executorHeartbeat(execId: String, taskMetrics: Array[(Long, Int, 
TaskMetrics)],
    +      blockManagerId: BlockManagerId): Boolean = {
    +    listenerBus.post(SparkListenerExecutorMetricsUpdate(execId, 
taskMetrics))
    +    implicit val timeout = Timeout(30 seconds)
    +
    +    Await.result(
    --- End diff --
    
    Also, could you add a comment here that explains what this returns? I 
realize you added this elsewhere for `TaskScheduler*`, but it would be good to 
comment it here too, so people who aren't following this chain of messages have 
a rough idea what's going on.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to