Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/10205#issuecomment-189108089
I thought a little about @andrewor14 's feedback and I came up with a
different API that seems a little cleaner; but I'd like feedback before making
more changes since it requires modifying all the current call sites in this
change.
Basically, I came up with a builder pattern, where you define the type at
the end. For example, for an int config:
private[spark] val DYN_ALLOCATION_MIN_EXECUTORS =
ConfigBuilder("spark.dynamicAllocation.minExecutors")
.doc("This is the doc string")
.internal()
.intConf(0)
Or the same config without a default, meaning it would be an `Option[Int]`:
private[spark] val DYN_ALLOCATION_MIN_EXECUTORS =
ConfigBuilder("spark.dynamicAllocation.minExecutors")
.doc("This is the doc string")
.internal()
.intConf
The only thing for me is that it's a little hard to spot when a config is
optional; maybe call the second method `optionalIntConf` instead of `intConf`
would make that stand out more.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
