Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/10205#issuecomment-189316556
Definitely like this change. I haven't done a full review but had a couple
questions.
I assume the intention of the doc is to eventually generate the web pages
from this string?
I think I like the Builder approach you have proposed a little better.
What exactly does optional mean? Is it just that there is no default or is
it that the config must be specified or we error?
If its just that there is no default, perhaps we should split it up and
make the type a separate parameter .int, .string, etc and then have a separate
one for defaultValue() and if that isn't specified then there is none implying
optional.
Would it make sense to also add in a validator function here? That could
always come later but thought I'd throw it out there. It might also cover the
other case of optional where this parameter has to be specified.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
