Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/12896#discussion_r62066768
--- Diff: python/pyspark/ml/tests.py ---
@@ -1027,6 +1027,21 @@ def test_storage_levels(self):
self.assertEqual(als.getFinalStorageLevel(), "DISK_ONLY")
self.assertEqual(als._java_obj.getFinalStorageLevel(), "DISK_ONLY")
+ def test_unknown_strategy(self):
--- End diff --
I see a similar test was added for the storage level params, but I don't
exactly understand why we need these. We don't implement these types of tests
for other classes and params and this is just checking the getters and setters.
Also, the `fit` call seems unnecessary.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
