Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/12896#discussion_r62070302
--- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala
---
@@ -71,6 +71,22 @@ private[recommendation] trait ALSModelParams extends
Params with HasPredictionCo
/** @group getParam */
def getItemCol: String = $(itemCol)
+
+ /**
+ * Param for strategy for dealing with unknown users or items at
prediction time.
+ * Supported values:
--- End diff --
I'm thinking I will create an example, or perhaps expand alsexample to
include cross validation, illustrating this.
It may make sense to add something in the comment.
On Wed, 4 May 2016 at 18:11, Seth Hendrickson <[email protected]>
wrote:
> In mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala
> <https://github.com/apache/spark/pull/12896#discussion_r62067878>:
>
> > @@ -71,6 +71,22 @@ private[recommendation] trait ALSModelParams extends
Params with HasPredictionCo
> >
> > /** @group getParam */
> > def getItemCol: String = $(itemCol)
> > +
> > + /**
> > + * Param for strategy for dealing with unknown users or items at
prediction time.
> > + * Supported values:
>
> Should we add a note here about this being useful/necessary when
> performing cross validation or evaluating the model on unseen data?
>
> â
> You are receiving this because you authored the thread.
> Reply to this email directly or view it on GitHub
>
<https://github.com/apache/spark/pull/12896/files/fc437451a598221f0878b7a2e0b87d17572019cc#r62067878>
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
