Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/12896#discussion_r62068526
--- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala
---
@@ -241,11 +261,17 @@ class ALSModel private[ml] (
Float.NaN
}
}
- dataset
+ val predictions = dataset
.join(userFactors, dataset($(userCol)) === userFactors("id"), "left")
.join(itemFactors, dataset($(itemCol)) === itemFactors("id"), "left")
.select(dataset("*"),
predict(userFactors("features"),
itemFactors("features")).as($(predictionCol)))
+ $(unknownStrategy) match {
+ case ALSModel.Drop =>
--- End diff --
For my own curiosity, is there a reason we can't just match on the string
value and avoid creating these new vals? Seems like I have seen both ways in
the code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
