Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/12896#discussion_r62098570
--- Diff: python/pyspark/ml/tests.py ---
@@ -1027,6 +1027,21 @@ def test_storage_levels(self):
self.assertEqual(als.getFinalStorageLevel(), "DISK_ONLY")
self.assertEqual(als._java_obj.getFinalStorageLevel(), "DISK_ONLY")
+ def test_unknown_strategy(self):
--- End diff --
I agree with @sethah that testing the setting/transferring of the Params
here is not needed and would be better to leave to the wrapper class to test.
Also, `_java_obj` is supposed to be a "private" variable and maybe not good for
the end user to think it's ok to use directly.
Perhaps a more useful test could be what happens if the user sets the Param
to an unsupported value, e.g.
```py
als.setUnknownStrategy("duh")
```
Is the expected behaviour that it would fail when `fit` is called? If so,
I don't think that's great, but that's more of a problem of the wrapper class
anyway.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
