Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/12896#discussion_r62096297
--- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala
---
@@ -268,6 +294,10 @@ class ALSModel private[ml] (
@Since("1.6.0")
object ALSModel extends MLReadable[ALSModel] {
+ private val NaN = "nan"
+ private val Drop = "drop"
+ private[recommendation] final val supportedUnknownStrategies =
Array(NaN, Drop)
--- End diff --
Instead of adding an array here, could you just create it in the
`ParamValidator` when defining the `Param`?
```scala
ParamValidators.inArray(Array(ALSModel.NaN, ALSModel.Drop))
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
